feature: [yurthub] improve list/watch node pool resource in serviceTopology fil… #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @rambohe-ch |
rambohe-ch
reviewed
Sep 7, 2021
cmd/yurthub/app/config/config.go
Outdated
| labelSelector = labelSelector.Add(*nodePoolLabel) | ||
| yurtSharedInformerFactory := yurtinformers.NewSharedInformerFactoryWithOptions(yurtClient, 24*time.Hour, | ||
| yurtinformers.WithTweakListOptions(func(options *metav1.ListOptions) { | ||
| options.LabelSelector = labelSelector.String() |
There was a problem hiding this comment.
metadata.name is field of object, so please use FieldSelector instead LabelSelector for metadata.name, then the code like as following:
options.FieldSelector = fields.Set{"metadata.name": string(nodePoolName)}.String()
There was a problem hiding this comment.
Thanks for your help. I have already modified.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neo502721, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ter (#421)
What type of PR is this?
What this PR does / why we need it:
to improve list/watch node pool resource in serviceTopology filter
Which issue(s) this PR fixes:
Fixes #421
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note
if user set the yurthub parameter "--nodepool-name". That will be add LabelSelector TweakListOptions to the nodepool-informer.